Take a second look at the private entries list

All suggestions about TPFC should be posted here. Discussions about changes to TPFC will also be carried out here.
Message
Author
User avatar
Andrew Lee
Posts: 3198
Joined: Sat Feb 04, 2006 9:19 am
Contact:

Re: Take a second look at the private entries list

#31 Post by Andrew Lee »

Andrew Lee wrote: Fri Feb 14, 2025 10:40 pm Got it! Will add to my todo list.
UPDATE: This has been implemented. In the case of the private entry having multiple categories, the first category returned by the database retrieval is selected.

lwc
Posts: 379
Joined: Tue Jun 26, 2012 10:40 pm
Contact:

Re: Take a second look at the private entries list

#32 Post by lwc »

Thanks! Meanwhile, the see private entries mode works for anonymous users too. i.e. if you choose it and log out (but keep the link) or when you manually add &rt=p. Better fix before search engines catch on (if they didn't already).
Also, if you click Public or Private it adds an extra &, i.e. &&rt=p or &&rt=f. It doesn't break anything, but should be avoided for clearer code.

User avatar
Andrew Lee
Posts: 3198
Joined: Sat Feb 04, 2006 9:19 am
Contact:

Re: Take a second look at the private entries list

#33 Post by Andrew Lee »

lwc wrote: Sun Feb 16, 2025 1:04 pm Also, if you click Public or Private it adds an extra &, i.e. &&rt=p or &&rt=f. It doesn't break anything, but should be avoided for clearer code.
Can you tell me in detail how to reproduce this? I am getting only a single '&" no matter what I try. Thanks!

User avatar
Andrew Lee
Posts: 3198
Joined: Sat Feb 04, 2006 9:19 am
Contact:

Re: Take a second look at the private entries list

#34 Post by Andrew Lee »

lwc wrote: Sun Feb 16, 2025 1:04 pm Thanks! Meanwhile, the see private entries mode works for anonymous users too. i.e. if you choose it and log out (but keep the link) or when you manually add &rt=p. Better fix before search engines catch on (if they didn't already).
This has been fixed. Thanks for the suggestion!

lwc
Posts: 379
Joined: Tue Jun 26, 2012 10:40 pm
Contact:

Re: Take a second look at the private entries list

#35 Post by lwc »

The double && seems fixed too, so I guess you did catch it, thanks!

lwc
Posts: 379
Joined: Tue Jun 26, 2012 10:40 pm
Contact:

Re: Take a second look at the private entries list

#36 Post by lwc »

There's another issue, if you look by username (/index.php?q=[username XYZ]) then it looks for both Public and Private entries no matter what you do.
It makes it hard to monitor one's still private entries...
Could you fix?

User avatar
Andrew Lee
Posts: 3198
Joined: Sat Feb 04, 2006 9:19 am
Contact:

Re: Take a second look at the private entries list

#37 Post by Andrew Lee »

lwc wrote: Fri Mar 14, 2025 5:22 pm There's another issue, if you look by username (/index.php?q=[username XYZ]) then it looks for both Public and Private entries no matter what you do.
It makes it hard to monitor one's still private entries...
Could you fix?
OK, added to todo list.

Please refer to this post.

So basically what you want to do is to add a '#' to the front of the username to see his private submissions.

- [username] alone simply list all the entries that the user has thumbed up, even those that has gone private.
(Note: all entries submitted by the user automatically goes under his "thumbed up aka. favorite" list)

- [@username] list all the user's submissions (both public and private).

- [#username] list all the user's submissions (private only).

tproli did suggest that I add these more arcane parameters to the detailed search page, but I must have decided against it because I assumed most people won't be interested. Well, no one asked until 13y later, so I was right :D

But I think maybe I would add it to a collapsible text block in the search details page so that I won't be forced to search through the forum for this again!

lwc
Posts: 379
Joined: Tue Jun 26, 2012 10:40 pm
Contact:

Re: Take a second look at the private entries list

#38 Post by lwc »

Andrew Lee wrote: Fri Mar 14, 2025 9:08 pm - [#username] list all the user's submissions (private only).
This one is broken.

Either way, by now even the homepage shows private entries when not being logged in...
Although please vote for the specific one from the screenshot to make it public. :D
Attachments
private.png

User avatar
Andrew Lee
Posts: 3198
Joined: Sat Feb 04, 2006 9:19 am
Contact:

Re: Take a second look at the private entries list

#39 Post by Andrew Lee »

lwc wrote: Sun Mar 16, 2025 11:16 am
Andrew Lee wrote: Fri Mar 14, 2025 9:08 pm - [#username] list all the user's submissions (private only).
This one is broken.
I think I figured out what's wrong and fixed it. Try again pls.
lwc wrote: Sun Mar 16, 2025 11:16 am Either way, by now even the homepage shows private entries when not being logged in...
Although please vote for the specific one from the screenshot to make it public. :D
This is due to increasing CloudFlare's security level to "I am under attack", which for some convoluted reason stopped the database statuses from updating when the entry score increases above the threshold (10). This has been fixed.

lwc
Posts: 379
Joined: Tue Jun 26, 2012 10:40 pm
Contact:

Re: Take a second look at the private entries list

#40 Post by lwc »

Andrew Lee wrote: Sun Mar 16, 2025 5:54 pm
lwc wrote: Sun Mar 16, 2025 11:16 am
Andrew Lee wrote: Fri Mar 14, 2025 9:08 pm - [#username] list all the user's submissions (private only).
This one is broken.
I think I figured out what's wrong and fixed it. Try again pls.
Sorry, still broken.
lwc wrote: Sun Mar 16, 2025 11:16 am Either way, by now even the homepage shows private entries when not being logged in...
Although please vote for the specific one from the screenshot to make it public. :D
This is due to increasing CloudFlare's security level to "I am under attack", which for some convoluted reason stopped the database statuses from updating when the entry score increases above the threshold (10). This has been fixed.
Hard to test since that aforementioned entry is now public. :D

User avatar
Andrew Lee
Posts: 3198
Joined: Sat Feb 04, 2006 9:19 am
Contact:

Re: Take a second look at the private entries list

#41 Post by Andrew Lee »

lwc wrote: Mon Mar 17, 2025 12:38 pm Sorry, still broken.
More details pls? For example, this search lists all your private submissions.
lwc wrote: Mon Mar 17, 2025 12:38 pm Hard to test since that aforementioned entry is now public. :D
Should be a one-off. Basically the score was already above 10, but the status wasn't updated to "New" because the periodic cron job aborted due to the CloudFlare change.

lwc
Posts: 379
Joined: Tue Jun 26, 2012 10:40 pm
Contact:

Re: Take a second look at the private entries list

#42 Post by lwc »

Andrew Lee wrote: Tue Mar 18, 2025 2:30 am
lwc wrote: Mon Mar 17, 2025 12:38 pm Sorry, still broken.
More details pls? For example, this search lists all your private submissions.
It's only because this link was manually encoded, probably so you can save it in the forum. q=%5B%23lwc%5D might work, but q=[#lwc] doesn't:
  1. portablefreeware.com/index.php?q=[lwc] - works, but*
  2. portablefreeware.com/index.php?q=%5Blwc%5D - works
  3. portablefreeware.com/index.php?q=[#lwc] - broken
  4. portablefreeware.com/index.php?q=%5B%23lwc%5D - works, but*
  5. portablefreeware.com/index.php?q=[@lwc] - works, but*
  6. portablefreeware.com/index.php?q=%5B%40lwc%5D - works
* But it has a weird Forum topics matching your query link at the beginning*, which upon clicking just opens a list of forum links, which meaning is hard to understand

So we have 2 works, 3 "works but", and 1 broken.

User avatar
Andrew Lee
Posts: 3198
Joined: Sat Feb 04, 2006 9:19 am
Contact:

Re: Take a second look at the private entries list

#43 Post by Andrew Lee »

lwc wrote: Tue Mar 18, 2025 10:05 am It's only because this link was manually encoded, probably so you can save it in the forum. q=%5B%23lwc%5D might work, but q=[#lwc] doesn't:
  1. portablefreeware.com/index.php?q=[lwc] - works, but*
  2. portablefreeware.com/index.php?q=%5Blwc%5D - works
  3. portablefreeware.com/index.php?q=[#lwc] - broken
  4. portablefreeware.com/index.php?q=%5B%23lwc%5D - works, but*
  5. portablefreeware.com/index.php?q=[@lwc] - works, but*
  6. portablefreeware.com/index.php?q=%5B%40lwc%5D - works
* But it has a weird Forum topics matching your query link at the beginning*, which upon clicking just opens a list of forum links, which meaning is hard to understand

So we have 2 works, 3 "works but", and 1 broken.
I think you cannot directly use certain characters in hyperlinks without encoding them. This includes the square brackets and quite a few other characters, including '#'. When you type these characters in a form and submit, the browser will take care of encoding these characters for you before sending them to the backend.

I can probably hide the "Forum topics matching your query" section for username queries only if you find that confusing. Can't think of any functional impact.

User avatar
Midas
Posts: 7010
Joined: Mon Dec 07, 2009 7:09 am
Location: Sol3

Re: Take a second look at the private entries list

#44 Post by Midas »

Andrew Lee wrote: I can probably hide the "Forum topics matching your query" section for username queries only if you find that confusing. Can't think of any functional impact.
From afar and given that showing "Forum topics matching your query" is the default for every search on the main page, I don't think that would be entirely advisable because it breaks consistency and user expectation -- couldn't it just return an empty list where necessary instead? :|

User avatar
Andrew Lee
Posts: 3198
Joined: Sat Feb 04, 2006 9:19 am
Contact:

Re: Take a second look at the private entries list

#45 Post by Andrew Lee »

Actually the "Forum topics matching your query" box is only shown if a forum search returns matches. If there are no matches, it will not be shown.

So what I done is to simply not perform forum searches for usernames, so the result list is empty, which means the forum topics box will not be shown for these cases.

Post Reply