Take a second look at the private entries list

All suggestions about TPFC should be posted here. Discussions about changes to TPFC will also be carried out here.
Message
Author
User avatar
Andrew Lee
Posts: 3199
Joined: Sat Feb 04, 2006 9:19 am
Contact:

Re: Take a second look at the private entries list

#16 Post by Andrew Lee »

Emka wrote: Sun Jan 26, 2025 12:11 am Hm, it seems it doesn't make a difference on my side when I click it...
My apologies, it has been fixed.
lwc wrote: Sun Jan 26, 2025 1:29 am Also, I think there should a third option called Both.
Any one else seconds this request? I can make it toggle between public/private/both, but I personally thinks toggling between public/private is cleaner.

Plus this option is still available under Detailed search (Results type, All), so if it isn't used that often, might be best to leave it there.

User avatar
rbon
Posts: 469
Joined: Wed Mar 28, 2007 2:16 am
Location: Italy

Re: Take a second look at the private entries list

#17 Post by rbon »

Hi Andrew,
good works, but the button "Private only" works only in first page: if you select second page (the page#2) you loose login and you cannot see anymore the button "Private only".
Do you can fix it ?

--- EDIT -----
I tried again and it works fine now.
I had previously tried the link in the first post and that messed up your query.
Last edited by rbon on Mon Jan 27, 2025 8:47 am, edited 1 time in total.
"Programming today is a race between software engineers striving to build bigger and better idiot-proof programs, and the universe trying to build bigger and better idiots. So far, the universe is winning." - Rick Cook.

User avatar
joby_toss
Posts: 3046
Joined: Sat Feb 09, 2008 9:57 am
Location: Romania
Contact:

Re: Take a second look at the private entries list

#18 Post by joby_toss »

Because it's implemented as a toggle, I think it's better to have only 2 options.

And thank you!

User avatar
Midas
Posts: 7011
Joined: Mon Dec 07, 2009 7:09 am
Location: Sol3

Re: Take a second look at the private entries list

#19 Post by Midas »

joby_toss wrote: Because it's implemented as a toggle, I think it's better to have only 2 options.
I second that for ergonomy's sake. :|

User avatar
vevy
Posts: 816
Joined: Tue Sep 10, 2019 11:17 am

Re: Take a second look at the private entries list

#20 Post by vevy »

You can do an option to cover all bases: make them checkboxes with defaults:
private.png
private.png (1.69 KiB) Viewed 9848 times

User avatar
vevy
Posts: 816
Joined: Tue Sep 10, 2019 11:17 am

Re: Take a second look at the private entries list

#21 Post by vevy »

There is also this:
Archive.png

User avatar
Rubber_Ducky
Posts: 4
Joined: Wed Jul 26, 2017 4:21 pm

Re: Take a second look at the private entries list

#22 Post by Rubber_Ducky »

If one toggles to "Private only" and, then, does a search for a specific term, the toggle is back to "Public only": I cannot think that this is desirable behaviour.
Last edited by Rubber_Ducky on Tue Jan 28, 2025 5:05 pm, edited 2 times in total.

User avatar
Andrew Lee
Posts: 3199
Joined: Sat Feb 04, 2006 9:19 am
Contact:

Re: Take a second look at the private entries list

#23 Post by Andrew Lee »

Rubber_Ducky wrote: Tue Jan 28, 2025 2:59 pm If one toggles to "Private only" and, then, does a search for a specific term, the toggle is back to "Public only": I cannot think that this is diserable behaviour.
Good catch, thanks! This will take a bit more time to fix, so pls be patient!

[edit]This issue has been fixed. Thanks for your patience.[/edit]

lwc
Posts: 380
Joined: Tue Jun 26, 2012 10:40 pm
Contact:

Re: Take a second look at the private entries list

#24 Post by lwc »

I have another debate - what about public entries linking to private entries?
For example, 3 out of 5 public entries in this category link to the private entry FileASSASSIN.
Maybe when not logging in should it be grayed out and unlinkable?
Or maybe it should be opened anyway because the non logged in obviously wanted to click it?

Either way it shouldn't act like a redirection link when not being logged in. It not only damages the (anonymous) user's experience, but probably damages SEO ranking too (since crawlers aren't supposed to be logged in).

User avatar
Andrew Lee
Posts: 3199
Joined: Sat Feb 04, 2006 9:19 am
Contact:

Re: Take a second look at the private entries list

#25 Post by Andrew Lee »

I have made a slight change such that trying to access a private entry if you are not logged in will trigger a 404.

It is not really practical to filter through the entry, check every link to see if they are private and mask them out.

But I will manually delete FileAssassin from those offending entries. If you guys see more, please manually edit as well.

Thanks!

lwc
Posts: 380
Joined: Tue Jun 26, 2012 10:40 pm
Contact:

Re: Take a second look at the private entries list

#26 Post by lwc »

But note your 404 looks empty in Firefox becuase there's 404 to the 404 i.e. your server didn't define any 404.
So it's up to the browser what to do and I guess Firefox decides in this case to show nothing.
Who knows, it might even get some browsers into an infinite loop...
Attachments
404 to 404.png

User avatar
Andrew Lee
Posts: 3199
Joined: Sat Feb 04, 2006 9:19 am
Contact:

Re: Take a second look at the private entries list

#27 Post by Andrew Lee »

lwc wrote: Sun Feb 09, 2025 1:19 am But note your 404 looks empty in Firefox becuase there's 404 to the 404 i.e. your server didn't define any 404.
So it's up to the browser what to do and I guess Firefox decides in this case to show nothing.
Who knows, it might even get some browsers into an infinite loop...
Thanks! I have fixed this by directing to the server 404 page after generating the header.

lwc
Posts: 380
Joined: Tue Jun 26, 2012 10:40 pm
Contact:

Re: Take a second look at the private entries list

#28 Post by lwc »

I have an alternate idea - how about instead of 404 redirect to the private entry's category? I mean, categories are never private so it will always work. Instead of a dead end, the user will at least get similar programs.

User avatar
Midas
Posts: 7011
Joined: Mon Dec 07, 2009 7:09 am
Location: Sol3

Re: Take a second look at the private entries list

#29 Post by Midas »

@lwc: Sounds like a good idea to me, as it'd enhance site usability... 8)

User avatar
Andrew Lee
Posts: 3199
Joined: Sat Feb 04, 2006 9:19 am
Contact:

Re: Take a second look at the private entries list

#30 Post by Andrew Lee »

Got it! Will add to my todo list.

Post Reply